-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Compute the doc range more efficiently when flushing doc block #14447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might still apply to Lucene103PostingsWriter
. Should we rebase?
Thanks for updating the PR to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the 10.3 postings writer! I'm happy to merge that change, but I would rather not mix in the 10.1 change since that release has already gone out and we're unlikely to release a follow-up unless we find serious bugs.
Could you also add an entry under 10.3 in CHANGES.txt?
Sorry, I don't know if I was clear enough. I was asking if we can also revert the change to Thanks for adding the changelog entry! |
My fault, I forgot to revert. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bugmakerrrrrr!
Description
Today, we sum all the doc delta to compute the range when flushing doc block, which is equivalent to
lastDocID - level0LastDocID
.