Skip to content

Compute the doc range more efficiently when flushing doc block #14447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025

Conversation

bugmakerrrrrr
Copy link
Contributor

Description

Today, we sum all the doc delta to compute the range when flushing doc block, which is equivalent to lastDocID - level0LastDocID.

Copy link
Contributor

@stefanvodita stefanvodita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might still apply to Lucene103PostingsWriter. Should we rebase?

@jainankitk
Copy link
Contributor

Thanks for updating the PR to include Lucene103PostingsWriter. LGTM!

Copy link
Contributor

@stefanvodita stefanvodita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the 10.3 postings writer! I'm happy to merge that change, but I would rather not mix in the 10.1 change since that release has already gone out and we're unlikely to release a follow-up unless we find serious bugs.

Could you also add an entry under 10.3 in CHANGES.txt?

@stefanvodita
Copy link
Contributor

Sorry, I don't know if I was clear enough. I was asking if we can also revert the change to Lucene101PostingsWriter and only change Lucene103PostingsWriter this time.

Thanks for adding the changelog entry!

@bugmakerrrrrr
Copy link
Contributor Author

Sorry, I don't know if I was clear enough. I was asking if we can also revert the change to Lucene101PostingsWriter and only change Lucene103PostingsWriter this time.

Thanks for adding the changelog entry!

My fault, I forgot to revert.

Copy link
Contributor

@stefanvodita stefanvodita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bugmakerrrrrr!

@stefanvodita stefanvodita merged commit 672f123 into apache:main Apr 23, 2025
7 checks passed
@gf2121 gf2121 added this to the 10.3.0 milestone Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants