Clean up how the test framework creates asserting scorables. #14452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `WrappedScorer` class and uses the existing `AssertingScorer` class instead.
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
jainankitk
reviewed
Apr 7, 2025
Comment on lines
-83
to
+78
| assert scoreMode == ScoreMode.TOP_SCORES; | ||
| assert canCallMinCompetitiveScore; | ||
| assert canScore; | ||
| assert canSetMinCompetitiveScore; |
There was a problem hiding this comment.
Still trying to understand this code better, but it seems that the assertion statement is weaker now. Earlier, it was specifically scoreMode == ScoreMode.TOP_SCORES, and now it is scoreMode.needsScores(). Do we allow it for other scoreMode that needsScores now?
There was a problem hiding this comment.
This is a good point, I pushed a commit that makes sure setMinCompetitiveScore may only be called with TOP_SCORES.
jainankitk
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
WrappedScorerclass and uses the existingAssertingScorerclass instead.