Create file open hints on IOContext to replace ReadAdvice #14482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
thecoop
commented
Apr 14, 2025
thecoop
force-pushed
the
iocontext-split
branch
3 times, most recently
from
7a36602 to
440ddf1
Compare
lucene/core/src/test/org/apache/lucene/store/TestDirectory.java
Outdated
Show resolved
Hide resolved
thecoop
force-pushed
the
iocontext-split
branch
from
440ddf1 to
808e7fa
Compare
|
To stop this PR getting too big, I suggest merging this here (which doesn't change any existing behaviour), and work on updating uses of IOContext to use hints rather than ReadAdvice in another PR |
This was referenced Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
IOContextand createFileOpenHintto specify how files are likely to be accessed once opened. This is the first PR of several to move from specifyingReadAdvicedirectly, to specifying the file usage context as hints and theReadAdvicebeing inferred from the hints insideDirectoryimplementations.Relates #14422