Skip to content

Upgrade to gradle 8.14-rc-2 #14519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

harshavamsi
Copy link

Description

I was trying to do a fresh import of Lucene into Intellij 2025.1 when it threw

java.lang.ClassCastException: class org.codehaus.groovy.runtime.GStringImpl cannot be cast to class java.lang.String (org.codehaus.groovy.runtime.GStringImpl is in unnamed module of loader org.gradle.internal.classloader.VisitableURLClassLoader @2280cdac; java.lang.String is in module java.base of loader 'bootstrap')
    in ToolingStreamApiUtils.writeCollection(ToolingStreamApiUtils.java:145)
FAILURE: Build failed with an exception.
* What went wrong:
java.io.NotSerializableException: org.gradle.api.internal.file.DefaultFilePropertyFactory$FixedFile
org.gradle.api.internal.file.DefaultFilePropertyFactory$FixedFile

Looks like the issue is related to gradle/gradle#32606 and is fixed in gradle 8.14. Raising this PR if we would want to upgrade to 8.14

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@dweiss
Copy link
Contributor

dweiss commented Apr 17, 2025

I would like to wait until the official release is made (not rc).

@harshavamsi
Copy link
Author

I would like to wait until the official release is made (not rc).

I'll mark this for draft and will pick up once 8.14 is fully released.

@harshavamsi harshavamsi marked this pull request as draft April 17, 2025 22:23
@dweiss
Copy link
Contributor

dweiss commented Apr 18, 2025

Don't get me wrong - please feel free to provide a pull request that passes with the rc release, this will make things easier! I just don't think we should merge it until the final release is available. If you browse the history of commits, you'll see what needs to be adjusted upon gradle upgrade - there are a couple of things (and I'm sure some things won't work anymore because gradle keeps banning what we liked to use...).

@harshavamsi
Copy link
Author

Don't get me wrong - please feel free to provide a pull request that passes with the rc release, this will make things easier! I just don't think we should merge it until the final release is available. If you browse the history of commits, you'll see what needs to be adjusted upon gradle upgrade - there are a couple of things (and I'm sure some things won't work anymore because gradle keeps banning what we liked to use...).

Thanks! I'll spend some time testing and seeing what else might need to change.

@dweiss
Copy link
Contributor

dweiss commented Apr 22, 2025

Please see #14533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants