testing: move cmocka_fs to the new folder /basic

[txy-21]

Summary

testing: move cmocka_fs to the new folder /basic

Move the cmocka case folder under testsuites to testing/fs/basic

Impact

apps/testing/testsuites and apps/testing/fs/basic

Testing

ci test.

[nuttxpr]

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements as described. While it provides some information, it lacks crucial details. Here's a breakdown:

• Insufficient Summary: While it states what is changed, it doesn't explain why. What problem does moving cmocka_fs solve? What are the benefits? How does the move work (e.g., just moving files, or code changes within the tests themselves)? There's no mention of related issues.

• Incomplete Impact Assessment: Simply listing affected directories isn't enough. Consider these questions:

  • New/Changed Feature: Is this just a reorganization or does it affect functionality?
  • User Impact: Likely no, but explicitly state it.
  • Build Impact: Will anything need to be changed in Makefiles or configuration?
  • Hardware Impact: Likely no, but explicitly state it.
  • Documentation Impact: Does this change require updating any documentation (e.g., test suite organization)?
  • Security Impact: Likely no, but explicitly state it.
  • Compatibility Impact: Likely no, but explicitly state it.

• Missing Testing Details: "ci test" isn't sufficient. Provide specific details:

  • Build Host: OS, CPU architecture, compiler version.
  • Target: Architecture (e.g., simulator, specific hardware), board and configuration.
  • Logs: Actual before and after logs demonstrating the change's effect (or explain why logs are not applicable, if that's the case). Just saying "ci test" doesn't show what was tested or the results of the test.

The PR description needs to be much more thorough to meet the NuttX requirements. Provide the missing context and details to make it clear why the change is necessary and that it has been properly validated.

[cederom]

CI failed, restarted.

[cederom]

Thank you @txy-21 :-)

• Please try to use relative paths (i.e. apps/testing/fs/basic) as /basic means a location in root directory so totally different place :-P
• I think the agreements was made before that test scenarios should be located in apps/tests/ while apps/testing/ was supposed to hold utilities and frameworks. Therefore target location should be apps/tests/cmocka/fs instead. Other cmocka tests could be placed there in analog way with functional location names. I have asked for confirmation in the original tests reorganization thread The placement of cases under testing is a bit messy, and cases of the same type need to be merged #2931.

[jerpelea]

please add a commit message

[txy-21]

Thank you @cederom :-)
In the previous discussion, I thought that the framework should be stored in apps/tests, and the specific cmocka test cases should be placed in the corresponding category under testing and named "category/basic", isn't that right?
These cmocka cases are missing cmakelist.txt, I will add it later.

[txy-21]

@jerpelea Got it, thank you for your reminder

[cederom]

@txy-21: Thank you @cederom :-) In the previous discussion, I thought that the framework should be stored in apps/tests, and the specific cmocka test cases should be placed in the corresponding category under testing and named "category/basic", isn't that right? These cmocka cases are missing cmakelist.txt, I will add it later.

Are you moving test scenarios (tests to be performed that return PASS/FAIL) or testing framework (some tool that is required to run the tests) @txy-21 ? :-) If test scenarios then correct location is apps/tests/... if testing framework then apps/testing/.... I think the conclusion was to separate testing frameworks / tools from test scenarios.

I can see mix of several things here that may need clarification / separation:

1. TESTS_TESTSUITES is described as "vela test suite". Why not use TESTS_VELA_SUITE then (or similar TESTS_CMOCKA_SUITE)?
2. As this seems Vela Test Suite shouldn't location be apps/testing/vela (or similar if this is Cmocka Test Suite then apps/testing/cmocka) ?
3. Renamed c and h files are in facts tests, right? If so these should be placed in apps/tests but not along test suite apps/testing right?
4. If these FS tests require cmocka / vela test suite then it would be best to put cmocka framework in apps/testing/cmocka and/or vela framework in apps/testing/vela, then group all cmocka tests in apps/tests/cmocka for instance FS tests in apps/tests/cmocka/fs so it is clear that these are test cases that require cmocka and are dedicated for filesystem?

What do you thinkg @raiden00pl @xiaoxiang781216 was that your thought? Is it doable to put Cmocka Framework in apps/testing/cmocka and cmocka tests in apps/tests/cmocka ? :-)