[JDBC] Part3: Plumb JDBC module to quarkus #1371
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
force-pushed
the
feature/integrate-jdbc-to-quarkus
branch
from
f5408af to
3efc11a
Compare
dimas-b
reviewed
Apr 16, 2025
...main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java
Outdated
Show resolved
Hide resolved
| return List.of( | ||
| new TestResourceEntry( | ||
| PostgresRelationalJdbcLifeCycleManagement.class, | ||
| Map.of(INIT_SCRIPT, "org/apache/polaris/admintool/relational-jdbc/init.sql"))); |
There was a problem hiding this comment.
How can this work in user's env. when we do not know the database type beforehand?
If this is only for testing, I believe it would be nicer to embed the SQL into java code (e.g. as """" strings).
There was a problem hiding this comment.
This is a test, just copied what we did Eclipse link, let me make this a inline Set of commands !
There was a problem hiding this comment.
I checked the present API apparantely we can just pass init script not a set of commands to be executed.
public SELF withInitScript(String initScriptPath) {
this.initScriptPaths = new ArrayList();
this.initScriptPaths.add(initScriptPath);
return (SELF)(this.self());
}
I am not sure if I missed something, please let me know,
...va/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java
Outdated
Show resolved
Hide resolved
singhpk234
force-pushed
the
feature/integrate-jdbc-to-quarkus
branch
2 times, most recently
from
6d6dcbd to
e701628
Compare
singhpk234
force-pushed
the
feature/integrate-jdbc-to-quarkus
branch
from
e701628 to
78da259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
This is part 3 of Bigger change #649
since part 2 is yet to be merged, and based on decision on part2 on how we wanna model relam, this PR depends. This PR contains both part 2 and part 3 commit. This PR models realms as Seperate schema (Discuss pending : https://lists.apache.org/thread/kvt3gd29hyxlhnwxr9b674s555jlvjjs) and how can this be plumbed to Polaris Admin and Service.
Complete Tasks break down
- [within extensions package or polaris-core/relational-jdbc ?]
- Add JDBC Query Generator
- Add Models
- Add JDBC Base Persistence Impl E2E