Support snapshots=refs #1405
Open
Support snapshots=refs #1405
+121
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-maynard
requested review from
adutra,
ashvina and
dennishuo
as code owners
eric-maynard
requested review from
dimas-b,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
singhpk234
reviewed
Apr 19, 2025
There was a problem hiding this comment.
Thanks @eric-maynard for picking this up ! this is a must !
...ests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java
Outdated
Show resolved
Hide resolved
...e/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
Outdated
Show resolved
Hide resolved
singhpk234
approved these changes
Apr 19, 2025
adutra
reviewed
Apr 21, 2025
...e/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
Outdated
Show resolved
Hide resolved
integration-tests/src/main/java/org/apache/polaris/service/it/env/CatalogApi.java
Outdated
Show resolved
Hide resolved
…g/iceberg/IcebergCatalogHandler.java Co-authored-by: Alexandre Dutra <[email protected]>
…env/CatalogApi.java Co-authored-by: Alexandre Dutra <[email protected]>
adutra
approved these changes
Apr 22, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IRC (and Polaris) spec states that a client can request a subset of snapshots when loading a table:
This PR adds support for the above.