Implement PolicyCatalogHandler and Add Policy Privileges Stage 2: AttachPolicy + DetachPolicy #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonahX
requested review from
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
HonahX
commented
Apr 21, 2025
Comment on lines
+34
to
+36
| public static PolarisResolvedPathWrapper getResolvedPathWrapper( | ||
| @Nonnull PolarisResolutionManifest resolutionManifest, | ||
| @Nonnull PolicyAttachmentTarget target) { |
There was a problem hiding this comment.
I plan to extract all getResolvedPathWrappers in PolicyCatalog to this util class to make them shared between PolicyCatalogHandler and PolicyCatalog
...ice/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandler.java
Show resolved
Hide resolved
| initializeCatalog(); | ||
| } | ||
|
|
||
| private PolarisAuthorizableOperation determinePolicyAttachmentOperation( |
There was a problem hiding this comment.
nit: this confused me when I first saw it called because it's talking about "Attachment" operations when half the time it's used for a "Detachment" operation. Maybe just determineRequiredOperation or something?
There was a problem hiding this comment.
Good point! How about determinePolicyMappingOperation? This name should represent both attachment and detachment.
...ice/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandler.java
Show resolved
Hide resolved
eric-maynard
previously approved these changes
Apr 22, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
eric-maynard
approved these changes
Apr 22, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #1357. It adds privilege and auth methods for
attachPolicyanddetachPolicy.The tests are in
PolicyCatalogHandlerAuthzTest.javacc: @flyrain