Equal terms DocTransformer #3317
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
commented
Apr 11, 2025
solr/core/src/java/org/apache/solr/response/transform/EqualTermsDocTransformer.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Gets the string field value, or null if not present or if found a list of values other than 1. | ||
| */ | ||
| private String getFieldValue(SolrDocument doc) { |
There was a problem hiding this comment.
I don't love the instance checks here... I wish there was a better typed API contract on the expected types.
solr/core/src/java/org/apache/solr/response/transform/EqualTermsDocTransformer.java
Outdated
Show resolved
Hide resolved
| @@ -365,26 +366,45 @@ private SolrInputDocument addRandomDocument(final int docId) | |||
|
|
|||
| final SolrInputDocument doc = | |||
| sdoc( | |||
| "id", "" + docId, | |||
There was a problem hiding this comment.
the newline placements are unfortunate; I can try to restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA TODO: https://issues.apache.org/jira/browse/SOLR-XXXXX
This is a sketch of a DocTransformer that emits a boolean field on the returned doc based on a document field being equal to an input stream, as compared by the analyzed text.
fl=id,isEqual:[equalterms field=subject value='John Smith']I need this for work but looking for feedback on inclusion in Solr and naming and other things.