cloneDeep: use structuredClone in platforms where that's possible
#12491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
requested review from
jerelmiller and
Copilot
and removed request for
jerelmiller
🦋 Changeset detectedLatest commit: 8662e58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
phryneas
changed the title
cloneDeep: use structuredClone in platform where that's possiblecloneDeep: use structuredClone in platforms where that's possible
There was a problem hiding this comment.
Pull Request Overview
This PR updates the cloneDeep implementation to use the native structuredClone API where available while preserving compatibility with React Native by maintaining a dedicated implementation. The key changes include:
- Refactoring cloneDeep in common/cloneDeep.ts to use structuredClone with a fallback.
- Introducing a new cloneDeep implementation for React Native in common/cloneDeep.react-native.ts.
- Export updates in index.react-native.ts and a corresponding changeset update.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utilities/index.react-native.ts | Updates module exports for React Native by referencing the new file. |
| src/utilities/common/cloneDeep.ts | Refactors cloneDeep to use structuredClone with a fallback. |
| src/utilities/common/cloneDeep.react-native.ts | Provides a React Native version of cloneDeep (duplicate helper definition present). |
| .changeset/nice-icons-approve.md | Documents the changeset for the cloneDeep refactor. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/utilities/common/cloneDeep.react-native.ts:41
- Duplicate definition of cloneDeepHelper detected; remove the redundant implementation to prevent confusion and potential maintenance issues.
function cloneDeepHelper<T>(val: T, seen?: Map<any, any>): T {
Comment on lines
+7
to
9
| } catch { | ||
| return value; | ||
| } |
There was a problem hiding this comment.
The fallback in cloneDeep returns the original value instead of performing a deep clone, which may result in unintended shared references; consider implementing a recursive deep cloning fallback for environments without structuredClone support.
Suggested change
| } catch { | |
| return value; | |
| } | |
| } catch { | |
| return deepClone(value); | |
| } | |
| } | |
| function deepClone<T>(value: T): T { | |
| if (value === null || typeof value !== 'object') { | |
| return value; | |
| } | |
| if (Array.isArray(value)) { | |
| const arrCopy = [] as any[]; | |
| for (const item of value) { | |
| arrCopy.push(deepClone(item)); | |
| } | |
| return arrCopy as any; | |
| } | |
| const objCopy = {} as { [key: string]: any }; | |
| for (const key in value) { | |
| if (Object.prototype.hasOwnProperty.call(value, key)) { | |
| objCopy[key] = deepClone((value as { [key: string]: any })[key]); | |
| } | |
| } | |
| return objCopy as T; |
Copilot uses AI. Check for mistakes.
|
commit: |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.