Skip to content

QueryInfo: only start watching cache if a network request is fired #12535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Apr 7, 2025

This might fix #12510 ?

There's still two tests behaving weirdly, but it seems promising.

Edit: This will likely be superseded by #12540 if that approach works out

Copy link

changeset-bot bot commented Apr 7, 2025

⚠️ No Changeset found

Latest commit: 2fdd040

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svc-apollo-docs
Copy link

svc-apollo-docs commented Apr 7, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: f693f861fdd4a50f72ca8b98

Copy link

pkg-pr-new bot commented Apr 7, 2025

npm i https://pkg.pr.new/@apollo/client@12535

commit: 2fdd040

Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 2fdd040
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/67f3e7888a11e1000823114b
😎 Deploy Preview https://deploy-preview-12535--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 41.37 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS) 50.83 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS) 47.91 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" 36.35 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) 33.75 KB (+0.05% 🔺)
import { ApolloProvider } from "@apollo/client/react" 1.26 KB (0%)
import { ApolloProvider } from "@apollo/client/react" (production) 1.24 KB (0%)
import { useQuery } from "@apollo/client/react" 9.94 KB (0%)
import { useQuery } from "@apollo/client/react" (production) 8.85 KB (0%)
import { useLazyQuery } from "@apollo/client/react" 9.32 KB (0%)
import { useMutation } from "@apollo/client/react" 3.62 KB (0%)
import { useMutation } from "@apollo/client/react" (production) 2.84 KB (0%)
import { useSubscription } from "@apollo/client/react" 4.42 KB (0%)
import { useSubscription } from "@apollo/client/react" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" 5.89 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" (production) 4.55 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" 5.38 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" (production) 4.04 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" 5.47 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" (production) 4.12 KB (0%)
import { useReadQuery } from "@apollo/client/react" 3.44 KB (0%)
import { useReadQuery } from "@apollo/client/react" (production) 3.37 KB (0%)
import { useFragment } from "@apollo/client/react" 2.36 KB (0%)
import { useFragment } from "@apollo/client/react" (production) 2.31 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrent Rendering Observer Leak
2 participants