Some minor updates to #260 #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmcewen
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Thanks @matt-graham, LGTM. I think DW was standing for Delta and Weights but precomp seems fine to me since that's what we've typically been using elsewhere (i.e. we haven't been specifying what is stored in the precomp elsewhere). And the docstring does explain what precomp should contain.
matt-graham
added a commit
that referenced
this pull request
Apr 23, 2025
#260) * add on-the-fly support for Fourier Wigner transforms * update custom ops test for new fourier wigner variable ordering * Some minor updates to #260 (#298) * Variable name and type hint cleanup * Refactor to remove repeated code --------- Co-authored-by: Matt Graham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (which is on top of #260) makes some small tidying updates to #260
DWDWargument toprecompsto make use more obvious. I wasn't sure what an appropriate name was here but followed the pattern of usingprecompsas a shorthand for precomputed values in other transform functions.Delta,Delta_elandQuadstodelta,delta_elandquadsto make compliant with PEP8 naming conventions.Tagging you for a review @jasonmcewen, mainly to check you are happy with the change from
DWtoprecompsas the argument name.