-
Notifications
You must be signed in to change notification settings - Fork 114
Docs: Add Range.size, update exavmlib deps #1505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-0.6
Are you sure you want to change the base?
Conversation
126ff63
to
6173560
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. This gets us one step closer to using ex_doc to create the documentation, and not be constrained to building documentation with OTP-26.0.2 or prior versions.
turns out Range.size was only added elixir 1.12 - so blocked for now:/ |
Maybe it can be conditionally included, we don't have but maybe there is another clever way to check if the Elixir version is high enough for it to be included. Also for reference: |
And a small fix to Base.ex adding @compile {:autoload, false}. This enables running mix docs on exexavmlib. mix docs --version 0.6.5 Signed-off-by: Peter M <[email protected]>
6173560
to
d9708ae
Compare
Thanks for the pointers, added I don't like having to do this - but I like future ex_doc support - hmm. |
I can see it leading to some confusion, since the function will appear in the documentation, but won't be available on VMs complied with an older version of Elixir. We should keep the |
And a small fix to Base.ex adding
@compile {:autoload, false}
.This enables running mix docs on exavmlib.
mix docs --version 0.6.5
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later