Skip to content

Add local copy of mailchimp assets. #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

freakboy3742
Copy link
Member

Uses local copies of the Mailchimp assets, rather than a CDN copy, to possibly avoid CORB issues.

Fixes #607.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 added the preview Approved for an automated preview label Apr 4, 2025
@freakboy3742 freakboy3742 marked this pull request as draft April 4, 2025 04:07
Copy link

github-actions bot commented Apr 4, 2025

Visit the preview URL for this PR (updated for commit a4b5865):

https://beeware-org--pr608-mailchimp-local-wqydbktl.web.app

(expires Fri, 11 Apr 2025 04:10:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b0da44bc067e7d9a4255c77cb2c5fce572218cec

@freakboy3742
Copy link
Member Author

@danyeaw This is an experiment to see if local assets fix the problem you were seeing. We can't reproduce post-json, which is the page that was giving you the CORB error - that appears to be a dynamic page, not a CDN-served asset.

Also - the preview URL isn't hosted in quite the same way as the production site, so this isn't a completely reliable test; but if you can subscribe using this URL:

https://beeware-org--pr608-mailchimp-local-wqydbktl.web.app/community/keep-informed/

it's definitely a positive sign. If it does work, the thing to check will be whether the preview site works generally - for example, does subscription work if you visit this url:

https://beeware-org--pr606-2025q2-tj4nn6bz.web.app/community/keep-informed/

That's the preview of #606, so it isn't using the local Mailchimp assets, but it is using the preview domain (which is a Google Cloud deployment). That will isolate whether it's being served by Github Pages that is the underlying issue.

@danyeaw
Copy link
Member

danyeaw commented Apr 4, 2025

This PR is working:
image

and so is PR606:
image

@freakboy3742
Copy link
Member Author

The fact that the older preview works suggests it's an issue with GitHub pages (or the CDN, or the node of the CDN that you're connected to)... but I have no idea how to fix that, short of not using form embedding...

@freakboy3742
Copy link
Member Author

Closing on the basis that it seems unlikely that it will solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Approved for an automated preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newsletter Subscription Fails with Cross Origin Errors
2 participants