wasmtime component: get InstancePre from Instance #10621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source types types::Component can be used to create an InstanceType (also added as a hidden method). The construction of InstancePre in the Linker calculates this information already, and the types::Compoonent is just storing Arcs to this information.
which retrieves an InstancePre corresponding to an Instance. All of the information needed to compute the InstancePre is already present in the Store under the Instances's index. This method is pub but doc(hidden) because it is just for typechecking (to be used in the bindings generator), so like other accessors of InstanceType or typecheck methods, it is not exposed in the public API.
github-actions
bot
added
the
wasmtime:api
… type table construct InstanceType right from the contents of InstancePre instead of using the intermediate ComponentType. The net is that InstancePre is just one word larger & one arc clone more expensive than before.
pchickey
changed the title
alexcrichton
approved these changes
Apr 21, 2025
pchickey
requested review from
dicej and
alexcrichton
and removed request for
a team and
dicej
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasmtime::component::InstancePregets a new field to hold an arc to the imported resources tableresource_types: Arc<PrimaryMap<ResourceIndex, ResourceType>>. This information is available at the two spots where anInstancePreis constructed (one of which is new, below), so theres no additional computation required here, just a clone of the arc.InstancePregets a new methodinstance_type(&self) -> InstanceType<'_>. TheInstanceTypeis used for typechecking. The whole purpose of this PR is so that typechecking can occur from either an Instance or InstancePre, and without taking a borrow into a Store, for the sake of wasmtime-wit-bindgen: Typecheck exports at {Foo}Indices construction #10610.wasmtime::component::Instancegets a new methodinstance_pre<T>(&self, store: &impl AsContext<Data = T>) -> InstancePre<T>. All of the information required to construct theInstancePreis already found in the Store at the Instances's index.