Memory and performance imrovements #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW... if you merge this, then it will get attached to the PR you opened on the original source. Unfortunately no one seems to be paying attention to it, which is another reason I opened the PR on your branch !! |
(cherry picked from commit eab3d41)
(cherry picked from commit e85342a)
When performing a OTA firmware update, we need to shutdown the HomeKit sever because all network processing (including pings) stop during file uploads. So system cannot process incoming TCP requests, risking out-of-memory crashes as buffers fill up.
|
hey, thanks for this. I am travelling at the moment and will merge once I get home. |
cfurter
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cfurter during development of HomeKit-RATGDO, @jgstroud and I found that we needed to make changes to Arduino-HomeKit-ESP8266 to make it more memory efficient and improve pairing reliability.
Although I started from the original HomeKit server, I found that I needed to pull in enhancements and fixes from others, including you. Your fork seems to be the furthest along and so I offer up this pull request that merges in the changes @jgstroud and I made, plus a minor one from @JKoss2.
As the commit history on my master branch is very messy, I started fresh from your master and attributed the changes to the author in the commit comment.
Hopefully you find this useful.