Skip to content

Refactor update_libchdb.sh for system-wide install and improve README #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2025

Conversation

JakkuSakura
Copy link
Contributor

This PR fixes deps so that it can use system-wide libchdb

The download script is tailored from https://clickhouse.com/docs/chdb/install/rust

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2025

CLA assistant check
All committers have signed the CLA.

@JakkuSakura JakkuSakura force-pushed the fix-deps branch 2 times, most recently from b969665 to c3a91cc Compare April 6, 2025 07:20
@auxten
Copy link
Member

auxten commented Apr 7, 2025

Pipeline failed, should be the same issue here chdb-io/chdb#318

@auxten
Copy link
Member

auxten commented Apr 7, 2025

The issue here is complex:

  1. chdb-rust is still using libchdb v2 API, and there are many unresolvable problems with session state or persistence. The main issue here is that the query function in libchdb v2 undergoes complete state recovery and system table initialization with each call. Therefore, the previous version locked chdb-rust's libchdb usage to v2.1.1.
  2. We have completed the upgrade of chdb Python binding, using connection-based API to circumvent the above issues, but chdb-rust has not yet completed the restructuring based on chdb v3.

Here is the action plan:

  1. First, complete the pipeline repair based on libchdb v2
  2. Complete the restructuring of chdb-rust based on libchdb v3.
  3. Merge this PR, as the modifications to update_libchdb.sh and README in this PR are very valuable.

@auxten
Copy link
Member

auxten commented Apr 7, 2025

I fix the pipeline by fix libchdb to v2.1.1, as the pipeline recover now. I will merge the PR, then the tasks left is:

  1. Complete the restructuring of chdb-rust based on libchdb v3.

@JakkuSakura Thanks for your contribution, and sorry for the trouble 🙏

@auxten auxten merged commit fac0fa3 into chdb-io:main Apr 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants