Skip to content

fix(query-core, vue-query): fix type inference in setQueryData when used in functions with explicit return types #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(query-core, vue-query): fix type inference in setQueryData when used in functions with explicit return types #1

wants to merge 4 commits into from

Conversation

arvi18
Copy link

@arvi18 arvi18 commented Apr 16, 2025

Applied the NoInfer utility type to the return type of setQueryData to prevent the outer function's return type from affecting the updater function's type inference.

closes TanStack#9024

@arvi18
Copy link
Author

arvi18 commented Apr 16, 2025

View your CI Pipeline Execution ↗ for commit 7c34847.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 4m 21s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-16 03:26:06 UTC

@arvi18
Copy link
Author

arvi18 commented Apr 16, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9030

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9030

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9030

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9030

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9030

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9030

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9030

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9030

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9030

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9030

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9030

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9030

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9030

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9030

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9030

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9030

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9030

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9030

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9030

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9030

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9030

commit: 7c34847

@arvi18
Copy link
Author

arvi18 commented Apr 16, 2025

The CI test failure seems unrelated to the changes in this PR. My changes only affect TypeScript type definitions and a type test, with no runtime behavior modifications. The failure appears to be in an unrelated test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setQueryData updater function's parameter incorrectly typed as unknown in expression body arrow functions
2 participants
@arvi18 @custardcream98