Skip to content

feat(schema-compiler): Support view extends #9507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 23, 2025

Makes it possible to inherit some views from others.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.07%. Comparing base (e0179c5) to head (41b634b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...cubejs-schema-compiler/src/compiler/CubeSymbols.ts 93.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9507      +/-   ##
==========================================
+ Coverage   59.02%   59.07%   +0.05%     
==========================================
  Files         153      153              
  Lines       13067    13079      +12     
  Branches     2223     2230       +7     
==========================================
+ Hits         7713     7727      +14     
+ Misses       5039     5037       -2     
  Partials      315      315              
Flag Coverage Δ
cube-backend 59.07% <94.11%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon changed the title feat(schema-compiler): Support folders via views extends feat(schema-compiler): Support view extends Apr 23, 2025
@KSDaemon KSDaemon force-pushed the feat/views-extends-folders branch from 41b634b to 60e8526 Compare April 24, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant