internal: (studio) initialize cloud studio asynchronously #31469
+751
−289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astone123
changed the title
astone123
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
10501-studio-telemetry
|
| Run status |
|
| Run duration | 18m 39s |
| Commit |
|
| Committer | astone123 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
9
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32147
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.2%
|
|
|---|---|
|
Untested elements
|
186
|
|
Tested elements
|
164
|
Accessibility
92.71%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
888
|
astone123
changed the title
|
@astone123 Lint is failing here |
astone123
changed the title
mschile
reviewed
Apr 22, 2025
| @@ -164,7 +164,12 @@ export interface CoreDataShape { | |||
| cloudProject: CloudDataShape | |||
| eventCollectorSource: EventCollectorSource | null | |||
| didBrowserPreviouslyHaveUnexpectedExit: boolean | |||
| studio: StudioManagerShape | null | |||
| studioLifecycleManager?: { | |||
There was a problem hiding this comment.
Would it make sense to put this type in the @types package similar to StudioManagerShape. So that we can have that type enforced in both places it's effectively used?
|
|
||
| if (studioManager.status === 'INITIALIZED') { | ||
| // Start studio manager initialization but don't block | ||
| const studioManagerPromise = getAndInitializeStudioManager({ |
There was a problem hiding this comment.
I'm wondering whether we could move this promise to be either part of the constructor for StudioLifecycleManager (so that it's not really mutable after its set). Or maybe even better, encapsulate this logic entirely inside of StudioLifecycleManager (but only if it's not super messy to do that).
mabela416
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We'd like to know how many people are using Cypress Studio today. This PR does a few things:
StudioLifecycleManagerto handle accessing StudioSteps to test
Ensure that studio still loads correctly - the cloud studio panel should still load when you pass the correct environment variables, and it should not when these variables are not provided.
Check the tests that I added that verify that the cloud code to collect telemetry is always called when Studio loads even if AI is not enabled.
How has the user experience changed?
Users shouldn't notice any changes to how Studio works today - the external user experience should remain unchanged.
PR Tasks
cypress-documentation?type definitions?