feat: extend Cypress.Keyboard.Keys and cy.press to support all keyboard keys #31496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/server/lib/automation/commands/key_press.ts:134
- The code mapping for 'ArrowUp' uses 'U+0010', which is also used for 'Shift' in this mapping. Please verify against the CDP specification and assign a unique key code for 'ArrowUp'.
'ArrowUp': 'U+0010',
| 'F11': '\uE03B', | ||
| 'F12': '\uE03C', | ||
| 'Escape': '\uE00C', | ||
| 'CapsLock': '\uE008', |
There was a problem hiding this comment.
The BiDi mapping for 'CapsLock' shares the same code ('\uE008') with 'Shift'. Each key should have a unique mapping, so please update one of them to the correct value according to the expected key codes.
Suggested change
| 'CapsLock': '\uE008', | |
| 'CapsLock': '\uE025', |
Copilot uses AI. Check for mistakes.
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
feat-all-keys
|
| Run status |
|
| Run duration | 13m 03s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
8
|
Flaky
|
1
|
Pending
|
380
|
Skipped
|
0
|
Passing
|
4997
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
16.76%
|
|
|---|---|
|
Untested elements
|
247
|
|
Tested elements
|
46
|
Accessibility
61.44%
|
|
|---|---|
|
Failed rules
|
6 critical
9 serious
4 moderate
0 minor
|
|
Failed elements
|
709
|
Tests for review
The first 5 failed specs are shown, see all 1423 specs in Cypress Cloud.
cypress/e2e/studio/studio.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > does not remove the studio url parameters if saving fails |
Test Replay
Screenshots
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?