Skip to content

Do not make a copy of PUB_CACHE, just create an empty one instead. #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

jonasfj
Copy link
Member

@jonasfj jonasfj commented Apr 10, 2025

Copying my 11GB PUB_CACHE crashed createThrowawayPubCache, something about Link. But fundamentally, it's probably almost as fast to just download the packages again.

And if we really want to avoid downloading the PUB_CACHE we could avoid global activate, or create a PUB_CACHE we can clone inside .dart_tool/.

But creating a copy of the default PUB_CACHE is not likely to be faster, and probably harder to do, since you can have entire git checkouts, and legacy packages that were extracted with system tar which might have symlinks inside them 🙈

(You could also argue I should clean up my 11GB PUB_CACHE, 🤣)

@jonasfj jonasfj requested a review from srawlins April 10, 2025 12:25
@szakarias szakarias merged commit 0388c64 into dart-lang:main Apr 22, 2025
9 checks passed
@jonasfj jonasfj deleted the dont-copy-pubcache branch April 22, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants