Last dask fixes #110
Merged
Last dask fixes #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Isaac Virshup <[email protected]>
lithomas1
commented
Mar 11, 2024
| @@ -44,7 +52,7 @@ | |||
| def svd(x: Array, full_matrices: bool = True, **kwargs) -> SVDResult: | |||
| if full_matrices: | |||
| raise ValueError("full_matrics=True is not supported by dask.") | |||
| return da.linalg.svd(x, **kwargs) | |||
| return da.linalg.svd(x, coerce_signs=False, **kwargs) | |||
There was a problem hiding this comment.
Needed sign dask will do a svd_flip on the data otherwise, which will make signs differ from numpy/scipy.
lithomas1
commented
Mar 12, 2024
| obj = np.asarray(obj).copy() | ||
| #print(obj) | ||
| return xp.array(obj, dtype=dtype, **copy_kwargs) | ||
| return xp.array(obj, copy=True, dtype=dtype) |
There was a problem hiding this comment.
I think I reverted back to the original changes here (before my dask PR), but it'd be good to make sure.
|
cc @asmeurer (This should be ready, but I'd like to test on what I have with scikit-learn again, to catch any bugs) |
|
I've verified that the fixes here don't break scikit-learn. |
|
ping @asmeurer |
asmeurer
reviewed
Mar 18, 2024
| @@ -37,6 +37,9 @@ array_api_tests/test_data_type_functions.py::test_finfo[float32] | |||
| # (I think the test is not forcing the op to be computed?) | |||
| array_api_tests/test_creation_functions.py::test_linspace | |||
|
|
|||
| # out.shape=(2,) but should be (1,) | |||
There was a problem hiding this comment.
Is there an upstream issue for this?
There was a problem hiding this comment.
Not yet - but I'll followup with dask
(I haven't been able to get this down to a MRE yet)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.