Skip to content

TYP: reject bool in the ord params of vector_norm and matrix_norm #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 19, 2025
Merged

TYP: reject bool in the ord params of vector_norm and matrix_norm #310

merged 4 commits into from
Apr 19, 2025

Conversation

jorenham
Copy link
Contributor

closes #309

@jorenham jorenham marked this pull request as ready for review April 17, 2025 20:36
@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 20:36
Copilot

This comment was marked as outdated.

Sign in to view

lucascolley
lucascolley approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Joren!

@lucascolley lucascolley merged commit 5e14b53 into data-apis:main Apr 19, 2025
23 checks passed
@jorenham jorenham deleted the typing/just branch April 19, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@lucascolley lucascolley lucascolley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TYP: tighten annotations for ord param
2 participants
@jorenham @lucascolley