Refactored corporate-member-join.js
#2043
Open
+29
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stopped using jQuery - Moved refactored code to `djangoproject.js` - Reused membership level data between event handlers
adamzap
commented
Apr 19, 2025
| const level_el = form_el.querySelector('#id_membership_level'); | ||
| const levels = [-Infinity, 2000, 5000, 12500, 30000, 100000]; | ||
|
|
||
| amount_el.addEventListener('change', function () { |
There was a problem hiding this comment.
There are many ways to implement the functionality for this handler, but this seemed to be the simplest to me.
adamzap
commented
Apr 19, 2025
| value = i; | ||
| } | ||
|
|
||
| level_el.value = value || ''; |
There was a problem hiding this comment.
The empty string sets the select back to the default selection.
adamzap
commented
Apr 19, 2025
| }); | ||
|
|
||
| level_el.addEventListener('change', function () { | ||
| amount_el.value = this.value ? levels[Number(this.value)] : ''; |
There was a problem hiding this comment.
The empty string sets the select back to the default selection.
Also, I don't think the Number conversion is strictly necessary here, but I using a string index for an array feels wrong.
pauloxnet
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
djangoproject.jsThis code affects two fields on the corporate member page: