CODEGEN-334 - Fix ignoreNoDocuments swallowing all errors, not just no document errors #10338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddeee888
commented
Apr 13, 2025
eddeee888
commented
Apr 13, 2025
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/cli |
5.0.6-alpha-20250415141129-37b66fad245f7c16d0eac1fd14cc0c7488f2c83f |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
4.6.1-alpha-20250415141129-37b66fad245f7c16d0eac1fd14cc0c7488f2c83f |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
4.5.1-alpha-20250415141129-37b66fad245f7c16d0eac1fd14cc0c7488f2c83f |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
4.8.1-alpha-20250415141129-37b66fad245f7c16d0eac1fd14cc0c7488f2c83f |
npm ↗︎ unpkg ↗︎ |
eddeee888
commented
Apr 13, 2025
eddeee888
commented
Apr 13, 2025
packages/graphql-codegen-cli/tests/test-files/graphql.config.json
Outdated
Show resolved
Hide resolved
💻 Website PreviewThe latest changes are available as preview in: https://pr-10338.graphql-code-generator.pages.dev |
1 task
🦋 Changeset detectedLatest commit: 37b66fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eddeee888
force-pushed
the
fix-ignore-no-doc-issue
branch
2 times, most recently
from
4387867 to
909e355
Compare
eddeee888
force-pushed
the
fix-ignore-no-doc-issue
branch
from
909e355 to
fa96556
Compare
eddeee888
force-pushed
the
fix-ignore-no-doc-issue
branch
2 times, most recently
from
438aeb7 to
2cac888
Compare
eddeee888
force-pushed
the
fix-ignore-no-doc-issue
branch
from
2cac888 to
304cd48
Compare
eddeee888
force-pushed
the
fix-ignore-no-doc-issue
branch
from
22b934e to
37b66fa
Compare
dotansimha
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related #9172
This PR fixes the issue where
ignoreNoDocumentsflag catches and swallows all errors such as syntax errors, and not just when no documents can be found. This uses feature implemented in ardatan/graphql-tools#7093Type of change
How Has This Been Tested?