Add Next.js setup with Docker support to publishers playground #8690
+1,864
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 14 out of 20 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- playground/publishers/Publishers.AppHost/Publishers.AppHost.csproj: Language not supported
- playground/publishers/adminportal/.dockerignore: Language not supported
- playground/publishers/adminportal/Dockerfile: Language not supported
- playground/publishers/adminportal/app/globals.css: Language not supported
- playground/publishers/adminportal/package.json: Language not supported
- playground/publishers/adminportal/tsconfig.json: Language not supported
|
|
||
| var created = await db.Database.EnsureCreatedAsync(); | ||
| if (created) | ||
| while (true) |
There was a problem hiding this comment.
Using an infinite loop for database creation retry may lead to an indefinite hang if the database setup continuously fails. Consider introducing a maximum retry count or an exponential backoff mechanism to prevent potential issues in production.
Suggested change
| while (true) | |
| const int maxRetryCount = 5; | |
| int retryCount = 0; | |
| int delay = 1000; // initial delay in milliseconds | |
| while (retryCount < maxRetryCount) |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Didn't work in deployed scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Next.js for improved JavaScript publishing scenarios and configure Docker for building and publishing the application.