[Automated] Update API Surface Area #8736
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
NO-MERGE
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
github-actions
bot
force-pushed
the
update-api-diffs
branch
3 times, most recently
from
7d0c9c2 to
c0d5f4c
Compare
mitchdenny
reviewed
Apr 15, 2025
| @@ -1982,16 +1995,28 @@ public void WriteConnectionString(ApplicationModel.IResource resource) { } | |||
| public System.Threading.Tasks.Task WriteEnvironmentVariablesAsync(ApplicationModel.IResource resource) { throw null; } | |||
| } | |||
|
|
|||
| [System.Diagnostics.CodeAnalysis.Experimental("ASPIREPUBLISHERS001")] | |||
| public sealed partial class NullPublishingActivityProgressReporter : IPublishingActivityProgressReporter | |||
There was a problem hiding this comment.
Should this be in Aspire.Hosting or Aspire.Hosting.Testing?
There was a problem hiding this comment.
That's a good question. I'm not 100% sure.
NullLogger is in Microsoft.Extensions.Logging.Abstractions. Although I don't think we have a logging testing package.
github-actions
bot
force-pushed
the
update-api-diffs
branch
2 times, most recently
from
a280eea to
f1e17ab
Compare
danmoseley
added
the
area-engineering-systems
github-actions
bot
force-pushed
the
update-api-diffs
branch
from
f1e17ab to
9c201c5
Compare
davidfowl
reviewed
Apr 18, 2025
| public IComputeEnvironmentResource? ComputeEnvironment { get { throw null; } set { } } | ||
|
|
||
| [System.Diagnostics.CodeAnalysis.Experimental("ASPIRECOMPUTE001")] | ||
| public IContainerRegistry? ContainerRegistryInfo { get { throw null; } set { } } |
There was a problem hiding this comment.
Why is this ContainerRegistryInfo and not ContainerRegistry @captainsafia ?
cc @eerhardt
github-actions
bot
force-pushed
the
update-api-diffs
branch
4 times, most recently
from
763d178 to
8a2e3d8
Compare
github-actions
bot
force-pushed
the
update-api-diffs
branch
from
8a2e3d8 to
cbed789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated update to the API surface to compare current surface vs latest release. This should only be merged once this surface area ships in a new release.