DRAFT: Basic implementation of build cache. #8754
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Apr 13, 2025
Comment on lines
27
to
+30
| ArgumentNullException.ThrowIfNull(runner); | ||
| ArgumentNullException.ThrowIfNull(interactionService); | ||
| ArgumentNullException.ThrowIfNull(projectLocator); | ||
| ArgumentNullException.ThrowIfNull(appHostBuilder); |
There was a problem hiding this comment.
Ya know, this argument null checking isn't really necessary 😄. We not shipping a public API.
davidfowl
reviewed
Apr 13, 2025
|
|
||
| private string GetAppHostStateBasePath(FileInfo projectFile) | ||
| { | ||
| var fullPath = projectFile.FullName; |
davidfowl
reviewed
Apr 14, 2025
|
|
||
| _ = logger; | ||
|
|
||
| var msBuildResult = await runner.GetProjectItemsAndPropertiesAsync( |
There was a problem hiding this comment.
How do we feel about transitivity here? You might need the same finger print for the closure of project refs (that aren't aspire projects).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a build cache for the Aspire CLI. It works by first executing msbuild to get a collection of properties and items and computing a hash of that content. If the inputs to the build have not changed, then they should remain the same. If a build has successfully completed successfully previously with the same hash then we don't bother triggering a build again.
This implementation has a few problems (not quite ready yet):
dotnet cleanis performed then the fingerprint will match but the outputs won't be available. We need to figure out the best way of validating that build outputs are available to run.--no-cacheoption to bothaspire runandaspire publish.aspire-run-with-cache.mp4