Add IMemoryPoolFactory and cleanup memory pool while idle #61554
+994
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
feature-iis
davidfowl
reviewed
Apr 18, 2025
| hostBuilder.ConfigureServices(services => | ||
| { | ||
| // Don't override an already-configured transport | ||
| services.TryAddSingleton<IConnectionListenerFactory, SocketTransportFactory>(); | ||
| //services.TryAddSingleton<IConnectionListenerFactory, SocketTransportFactory>(); |
There was a problem hiding this comment.
Suggested change
| //services.TryAddSingleton<IConnectionListenerFactory, SocketTransportFactory>(); |
3 tasks
davidfowl
reviewed
Apr 19, 2025
| /// <summary> | ||
| /// Optional callback to call when pool is being disposed. | ||
| /// </summary> | ||
| public Action<PinnedBlockMemoryPool>? DisposeCallback { get; set; } |
davidfowl
reviewed
Apr 19, 2025
| } | ||
|
|
||
| // https://github.com/dotnet/runtime/blob/db681fb307d754c3746ffb40e0634e4c4e0caa9e/docs/design/features/ScalableApproximateCounting.md | ||
| static void ScalableCount(ref uint counter) |
There was a problem hiding this comment.
But it's #if'd out.... is this here just in case you find you have false sharing?
davidfowl
reviewed
Apr 19, 2025
|
|
||
| #nullable enable | ||
|
|
||
| internal sealed class DefaultMemoryPoolFactory : IMemoryPoolFactory<byte>, IDisposable |
There was a problem hiding this comment.
IAsyncDisposable and capture the task and wait for it to end?
davidfowl
reviewed
Apr 19, 2025
|
|
||
| _pools.TryAdd(pool, pool); | ||
|
|
||
| pool.DisposeCallback = (self) => |
There was a problem hiding this comment.
Maybe not a big deal, but we can avoid the closure if you passed in state to the registration 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61003