Corrections to the mage.exe page #45836
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
dotnet-framework/svc
community-contribution
gewarren
approved these changes
Apr 21, 2025
| |**-t, -ToFile** `filePath`|Specifies the output path of the file that has been created or modified.| | ||
| |**-a, -Algorithm**|Specifies the algorithm to generate dependency digests with. Value must be "sha256RSA" or "sha1RSA.| |
There was a problem hiding this comment.
Suggested change
| |**-a, -Algorithm**|Specifies the algorithm to generate dependency digests with. Value must be "sha256RSA" or "sha1RSA.| | |
| |**-a, -Algorithm**|Specifies the algorithm to generate dependency digests with. The value must be "sha256RSA".| |
There was a problem hiding this comment.
Can you also place this option first so it's alphabetical?
| @@ -78,7 +78,9 @@ The following table shows the options supported by the `-Sign` command, which ap | |||
| |**-csp, -CryptoProvider** `provider-name`|Specifies the name of a cryptographic service provider (CSP) that contains the private key container. This option requires the **-KeyContainer** option.<br/><br/>This option is available starting with .NET Framework 4.7.| | |||
| |**-kc, -KeyContainer** `name`|Specifies the key container that contains the name of the private key. This option requires the **CryptoProvider** option.<br/><br/>This option is available starting with .NET Framework 4.7.| | |||
| |**-pwd, -Password** `passwd`|The password that is used for signing a manifest with a digital certificate. Must be used in conjunction with the **-CertFile** option.| | |||
| |**-ti, -TimestampUri** `uri`|The URL of a digital timestamping service. Timestamping the manifests prevents you from having to re-sign the manifests should your digital certificate expire before you deploy the next version of your application.| | |||
There was a problem hiding this comment.
Suggested change
| |**-ti, -TimestampUri** `uri`|The URL of a digital timestamping service. Timestamping the manifests prevents you from having to re-sign the manifests should your digital certificate expire before you deploy the next version of your application.| | |
| |**-ti, -TimestampUri** `uri`|The URL of a digital timestamping service. Timestamping the manifests prevents you from having to re-sign the manifests if your digital certificate expires before you deploy the next version of your application.| |
gewarren
reviewed
Apr 21, 2025
| @@ -42,7 +42,7 @@ The following table shows the options supported by the `-New` and `-Update` comm | |||
|
|
|||
| |Options|Default Value|Applies To|Description| | |||
| |-------------|-------------------|----------------|-----------------| | |||
| |**-a, -Algorithm**|sha1RSA|Application manifests.<br /><br /> Deployment manifests.|Specifies the algorithm to generate dependency digests with. Value must be "sha256RSA" or "sha1RSA.<br /><br /> Use with the "-Update" option. This option is ignored when using the "-Sign" option| | |||
| |**-a, -Algorithm**|sha1RSA|Application manifests.<br /><br /> Deployment manifests.|Specifies the algorithm to generate dependency digests with. Value must be "sha256RSA" or "sha1RSA.<br /><br /> Use with the "-Update" option.| | |||
There was a problem hiding this comment.
Suggested change
| |**-a, -Algorithm**|sha1RSA|Application manifests.<br /><br /> Deployment manifests.|Specifies the algorithm to generate dependency digests with. Value must be "sha256RSA" or "sha1RSA.<br /><br /> Use with the "-Update" option.| | |
| |**-a, -Algorithm**|sha1RSA|Application manifests.<br /><br /> Deployment manifests.|Specifies the algorithm to generate dependency digests with. Value must be "sha256RSA" or "sha1RSA".<br /><br /> Use with the "-Update" option.| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #35326
It makes necessary corrections to the mage.exe page such as:
-aoption with-Sign-SigncommandThose newly added are
-TimestampUriand-Algorithm. They are mostly copy-paste from the general table, however, I removed "Use with -update option" statement fromAlgorithm, since I couldn't see that requirement when applying in-Signcontext.Internal previews