Skip to content

Fix CarouselView layout SR6 regressions #29035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

albyrock87
Copy link
Contributor

Description of Change

A new PR based on main with changes from #28955.

Issues Fixed

Fixes #28930

@albyrock87 albyrock87 requested a review from a team as a code owner April 16, 2025 17:15
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 16, 2025
@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho
Copy link
Member

Seems we are removing some stuff needed from the Appium helpers..

C:\a\_work\1\s\src\Controls\tests\TestCases.Shared.Tests\Tests\Issues\Issue14497.cs(20,33): error CS1061: 'IApp' does not contain a definition for 'GetShellSearchHandler' and no accessible extension method 'GetShellSearchHandler' accepting a first argument of type 'IApp' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\tests\TestCases.Android.Tests\Controls.TestCases.Android.Tests.csproj]
C:\a\_work\1\s\src\Controls\tests\TestCases.Shared.Tests\Tests\Issues\Issue14497.cs(20,33): error CS1061: 'IApp' does not contain a definition for 'GetShellSearchHandler' and no accessible extension method 'GetShellSearchHandler' accepting a first argument of type 'IApp' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\tests\TestCases.iOS.Tests\Controls.TestCases.iOS.Tests.csproj]
C:\a\_work\1\s\src\Controls\tests\TestCases.Shared.Tests\Tests\Issues\Issue14497.cs(20,33): error CS1061: 'IApp' does not contain a definition for 'GetShellSearchHandler' and no accessible extension method 'GetShellSearchHandler' accepting a first argument of type 'IApp' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\tests\TestCases.Mac.Tests\Controls.TestCases.Mac.Tests.csproj]
C:\a\_work\1\s\src\Controls\tests\TestCases.Shared.Tests\Tests\Issues\Issue14497.cs(20,33): error CS1061: 'IApp' does not contain a definition for 'GetShellSearchHandler' and no accessible extension method 'GetShellSearchHandler' accepting a first argument of type 'IApp' could be found (are you missing a using directive or an assembly reference?) [C:\a\_work\1\s\src\Controls\tests\TestCases.WinUI.Tests\Controls.TestCases.WinUI.Tests.csproj]

@rmarinho rmarinho added this to the .NET 9 SR6.1 milestone Apr 17, 2025
@rmarinho rmarinho moved this from Todo to In Progress in MAUI SDK Ongoing Apr 17, 2025
@albyrock87 albyrock87 force-pushed the fix-28930-carousel-view branch from 5573c66 to 79b2a24 Compare April 17, 2025 14:14
@albyrock87 albyrock87 force-pushed the fix-28930-carousel-view branch from 79b2a24 to 2d0b5d8 Compare April 17, 2025 14:16
@dotnet dotnet deleted a comment from azure-pipelines bot Apr 17, 2025
@dotnet dotnet deleted a comment from PureWeen Apr 17, 2025
@PureWeen PureWeen moved this from In Progress to Ready To Review in MAUI SDK Ongoing Apr 21, 2025
@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Apr 22, 2025
@dotnet dotnet deleted a comment from azure-pipelines bot Apr 22, 2025
@dotnet dotnet deleted a comment from PureWeen Apr 22, 2025
@PureWeen PureWeen changed the base branch from main to inflight/candidate April 22, 2025 20:22
@PureWeen PureWeen merged commit 76baabc into dotnet:inflight/candidate Apr 22, 2025
128 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Apr 22, 2025
PureWeen added a commit that referenced this pull request Apr 23, 2025
### Description of Change

## .NET MAUI Release Notes - Inflight/Candidate

## What's Changed

### MAUI Product Fixes
* Fix CarouselView layout SR6 regressions by @albyrock87 in
#29035
* Revert "[Android] picker - focus/unfocus events (#28122)" by @PureWeen
in https://github.com/dotnet/maui/pull/1fb5164929
* [Windows] Fixed the flyout content width not being set correctly after
updating to WinUI SDK 1.7 by @Tamilarasan-Paranthaman in
#28996
* [Android] picker - focus/unfocus events by @kubaflo in
#28122
* [XC] add IRootObjectProvider by @StephaneDelcroix in
#28310
* [iOS] Fix for the File.ContentType from MediaPicker not being in valid
MIME format by @SyedAbdulAzeemSF4852 in
#28842
* [Android] Fixed the Incorrect Text Color Applied to Selected Tab in
TabbedPage by @Ahamed-Ali in #28844
* [iOS] Fix FlyoutPage does not respond to changes in the
FlyoutLayoutBehavior property by @devanathan-vaithiyanathan in
#28884
* [Android] Fixed ScalingCanvas.SetBlur not working by
@NirmalKumarYuvaraj in #28911
* [iOS] - Resolved Proper Rendering of Dynamic Header/Footer Updates in
CV2 by @prakashKannanSf3972 in #28641
* [iOS] Fixed the TargetInvocationException Occurs When Selecting
Header/Footer After Changing ItemsLayout in CV2 by @Ahamed-Ali in
#28890
* [Windows] - Fix Visual State Issue with Picker TextColor After
Navigation by @prakashKannanSf3972 in
#28746

### Dependency Updates
* [Windows] Upgrade to Windows App SDK 1.7 by @MartyIX in
#28499

### Testing
* [Testing] Feature Matrix UITest Cases for CollectionView EmptyView
Feature by @NafeelaNazhir in #28679
* Fixed Test case failure in PR 29037 - [2025/04/21] Candidate by
@HarishKumarSF4517 in #29049

**Full Changelog**:
main...inflight/candidate


For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community ✨ Community Contribution
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect label LineBreakMode in IOS inside CarouselView
3 participants