Skip to content

Add the test verifying property functions used in dotnet console/webapp don't need a reflection #48475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GangWang01
Copy link
Member

Fixes dotnet/msbuild#10406

ToolLocationHelper property functions still require reflection and it's tracked by dotnet/msbuild#10411. For other functions the test is covered.

ReceiverType ObjectInstanceType MethodName
Microsoft.Build.Utilities.ToolLocationHelper GetPlatformSDKLocation(String, String)
Microsoft.Build.Utilities.ToolLocationHelper GetPlatformSDKDisplayName(String, String)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 15, 2025
@GangWang01 GangWang01 marked this pull request as ready for review April 16, 2025 01:34
@Copilot Copilot AI review requested due to automatic review settings April 16, 2025 01:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • test/TestAssets/TestProjects/MSBuildBareBonesProject/BareBones.proj: Language not supported
Comments suppressed due to low confidence (2)

test/Microsoft.NET.Build.Tests/EvaluatorFastPathTests.cs:58

  • Consider verifying that the log file exists before reading from it to prevent potential exceptions if the file is missing.
var lines = File.ReadAllLines(logPath);

test/Microsoft.NET.Build.Tests/EvaluatorFastPathTests.cs:28

  • [nitpick] Consider extracting the log file name "PropertyFunctionsRequiringReflection" into a named constant to avoid duplication and potential discrepancies in future updates.
var logPath = Path.Combine(testAsset.Path, "PropertyFunctionsRequiringReflection");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Add test verifying no fast path evaluators are not needed by SDK
1 participant