Skip to content

ci: add problem matcher for clang output #46577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Apr 9, 2025

Description of Change

Adds a GitHub actions problem matcher to turn warnings/errors in the build output into warning/error annotations on the workflow runs so they're more discoverable.

Blocked by actions/runner#3802 as the relative paths in our build errors are relative to src/out/Default/ but the problem matcher constructs absolute paths from the workspace directory - there's no way to get src into the constructed path as it doesn't occur in either the workspace directory or the relative path in the error.

Checklist

  • PR description included and stakeholders cc'd

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 9, 2025
@dsanders11 dsanders11 changed the title Ci/clang problem matcher ci: add problem matcher for clang output Apr 9, 2025
@electron-cation electron-cation bot added semver/none and removed new-pr 🌱 PR opened in the last 24 hours labels Apr 9, 2025
@dsanders11 dsanders11 force-pushed the ci/clang-problem-matcher branch 2 times, most recently from 530e347 to 787f111 Compare April 9, 2025 22:34
@dsanders11 dsanders11 force-pushed the ci/clang-problem-matcher branch from 787f111 to 800d5e8 Compare April 10, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant