fix: layout improvements #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nzakas
requested review from
Copilot and
amareshsm
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/components/editor.tsx:134
- Review the new calc expressions used (e.g. calc(100%-72px) and calc(100%-57px)) to ensure that the syntax without spaces is parsed correctly in your Tailwind configuration, and that it produces the expected layout.
"h-[calc(100%-72px)]": readOnly,
src/App.tsx:51
- Changing from a calculated height (70dvh) to h-full may lead to unexpected behavior if the parent container does not have an explicit height set; please verify that the parent container styles support this change.
"<div className=\"bg-muted overflow-auto h-full relative flex flex-col\">",
nzakas
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Nice work, this looks really good.
Would like @amareshsm to review before merging.
|
@xbinaryx it looks like we have some merge conflicts now. Can you take a look? |
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What changes did you make? (Give an overview)
Related Issues
Closes #50
Is there anything you'd like reviewers to focus on?