Skip to content

fix: Remove wrong container-type property patch #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link

@skyclouds2001 skyclouds2001 commented Mar 26, 2025

depends on mdn/data#955, and as a mirror of csstree#313

Copy link

linux-foundation-easycla bot commented Mar 26, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: skyclouds2001 / name: skyclouds2001 (6122717)

@eslint-github-bot
Copy link

Hi @skyclouds2001!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@eslint-github-bot
Copy link

Hi @skyclouds2001!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@skyclouds2001 skyclouds2001 changed the title Remove wrong container-type property patch fix: Remove outdated container-type property patch Mar 26, 2025
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Mar 26, 2025
@skyclouds2001 skyclouds2001 marked this pull request as draft March 26, 2025 18:01
@nzakas
Copy link
Member

nzakas commented Mar 26, 2025

Thanks. When mdn/data#955 is merged and released we can take a look. Generally after updating mdn-data, we run npm run review:syntax-patch to update the patch file.

@skyclouds2001 skyclouds2001 changed the title fix: Remove outdated container-type property patch fix: Remove wrong container-type property patch Mar 27, 2025
@skyclouds2001
Copy link
Author

skyclouds2001 commented Mar 27, 2025

the case is that csstree' one is a wrong patch (which allows some values like normal size is invalid per browser's implement and latest spec); while mdn-data's one is outdated; and mdn/data#955 is intended to update mdn-data's one to match the latest spec and also the browser's implement

I'm guessing that the patch can not automated removed by the script

@nzakas
Copy link
Member

nzakas commented Mar 27, 2025

I guess we'll find out. 😄

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14090284576

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.601%

Totals Coverage Status
Change from base Build 13973107209: 0.0%
Covered Lines: 11671
Relevant Lines: 11803

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants