Skip to content

feat: add TypeScript parser support to playground #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Added an option called Parser under the section Versioning and Configuration to enable @typescript-eslint/parser in playground.

Related Issues

#709

Is there anything you'd like reviewers to focus on?

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit e5eaa64
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/67f90af6ef255500089be660
😎 Deploy Preview https://deploy-preview-714--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e5eaa64
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/67f90af68c260d0008fdebcc
😎 Deploy Preview https://deploy-preview-714--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit e5eaa64
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/67f90af699795400088403d9
😎 Deploy Preview https://deploy-preview-714--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit e5eaa64
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/67f90af608b5ae0008b7500b
😎 Deploy Preview https://deploy-preview-714--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit e5eaa64
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/67f90af65262b30008ef7b56
😎 Deploy Preview https://deploy-preview-714--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit e5eaa64
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/67f90af67cb1c500086450f0
😎 Deploy Preview https://deploy-preview-714--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit e5eaa64
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/67f90af608b5ae0008b75010
😎 Deploy Preview https://deploy-preview-714--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit e5eaa64
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/67f90af62e8df200086f733c
😎 Deploy Preview https://deploy-preview-714--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tanujkanti4441 Tanujkanti4441 marked this pull request as ready for review April 4, 2025 14:49
@snitin315 snitin315 moved this from Needs Triage to Implementing in Triage Apr 8, 2025
@nzakas
Copy link
Member

nzakas commented Apr 10, 2025

This is looking good! Can we make the default parser option say "Espree (default)"?

@snitin315 this is waiting for your re-review.

Comment on lines +173 to +175
...(options?.languageOptions.parser && {
parser: typeScriptESLintParser,
}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure to pass the languageOptions.sourceType correctly to parserOptions.sourceType in case of typeScriptESLintParser, More information here eslint/eslint#19563 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Implementing
Development

Successfully merging this pull request may close these issues.

3 participants