-
-
Notifications
You must be signed in to change notification settings - Fork 67
feat: add TypeScript
parser support to playground
#714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add TypeScript
parser support to playground
#714
Conversation
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for new-eslint ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is looking good! Can we make the default parser option say "Espree (default)"? @snitin315 this is waiting for your re-review. |
...(options?.languageOptions.parser && { | ||
parser: typeScriptESLintParser, | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure to pass the languageOptions.sourceType
correctly to parserOptions.sourceType
in case of typeScriptESLintParser, More information here eslint/eslint#19563 (comment)
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Added an option called
Parser
under the sectionVersioning and Configuration
to enable@typescript-eslint/parser
in playground.Related Issues
#709
Is there anything you'd like reviewers to focus on?