Skip to content

p2p: add metrics for inbound connection errors #31652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cskiraly
Copy link
Collaborator

Add metics detailing reasons we reject inbound connections for, and reasons these connections fail during the handshake.

Signed-off-by: Csaba Kiraly <[email protected]>

# Conflicts:
#	p2p/metrics.go
@cskiraly cskiraly requested review from fjl and zsfelfoldi as code owners April 16, 2025 12:49
@cskiraly
Copy link
Collaborator Author

Eventually, we could change this to

  • define metics as "bidirectional metrics", together with the dial metrics,
  • use markConnError(inbound bool, err error) wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant