Skip to content

Import/namespace and test extension handling cleanup in soltest #16013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: evmasm-test-case
Choose a base branch
from

Conversation

cameel
Copy link
Member

@cameel cameel commented Apr 19, 2025

Depends on #16012.

This is a bunch of refactors I extracted from #16012:

  • We have lists of test file extensions hard-coded in two places, which is error-prone. The PR unifies them.
  • Removal of unused imports in files where I spotted them.
  • In some places we use the annoying, verbose solidity::test:: prefix for CommonOptions and other things, in others we don't. Often we do both in the same file. This PR removes it.

It's a pure refactor, there are no functionality changes.

@cameel cameel added testing 🔨 has dependencies The PR depends on other PRs that must be merged first refactor labels Apr 19, 2025
@cameel cameel requested review from r0qs and aarlt April 19, 2025 07:43
@cameel cameel self-assigned this Apr 19, 2025
@cameel cameel force-pushed the evmasm-test-case branch 2 times, most recently from 1fd7f7d to ce8ca0a Compare April 19, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has dependencies The PR depends on other PRs that must be merged first refactor testing 🔨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant