Skip to content

ignore androidx when searching binder #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ignore androidx when searching binder #239

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00bca57
ignore androidx when searching binder
cooperkong Apr 11, 2019
8ba8f80
ignore searching in androidx for model binder
cooperkong Apr 11, 2019
4e16cf6
fix spotlessjava
cooperkong Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dart/src/main/java/dart/Dart.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ private static Method findExtraBinderForClass(Class<?> cls) throws NoSuchMethodE
return bind;
}
String clsName = cls.getName();
if (clsName.startsWith("android.") || clsName.startsWith("java.")) {
if (clsName.startsWith("android.")
|| clsName.startsWith("java.")
|| clsName.startsWith("androidx.")) {
if (debug) Log.d(TAG, "MISS: Reached framework class. Abandoning search.");
return NO_OP;
}
Expand Down Expand Up @@ -205,7 +207,9 @@ private static Method findNavigationModelBinderForClass(Class<?> cls)
return bind;
}
String clsName = cls.getName();
if (clsName.startsWith("android.") || clsName.startsWith("java.")) {
if (clsName.startsWith("android.")
|| clsName.startsWith("java.")
|| clsName.startsWith("androidx.")) {
if (debug) Log.d(TAG, "MISS: Reached framework class. Abandoning search.");
return NO_OP;
}
Expand Down