[in progress] Curio Snark Marketplace #484
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexLuthr
reviewed
Apr 17, 2025
Comment on lines
+45
to
+47
| ticker := time.NewTicker(10 * time.Second) | ||
| go func() { | ||
| for range ticker.C { |
There was a problem hiding this comment.
Wouldn't this goroutine keep running forever?
| SET compute_task_id = $1 | ||
| WHERE service_id = $2 | ||
| RETURNING service_id | ||
| `, taskID, serviceID).Scan(&serviceID) |
There was a problem hiding this comment.
Why are scanning the serviceID here? Did we plan to match with the old one?
|
|
||
| // If we don't have a client request yet, create one | ||
| if errors.Is(err, pgx.ErrNoRows) { | ||
| sectorInfo, err := t.getSectorInfo(ctx, taskID) |
There was a problem hiding this comment.
Can't we just pass this from caller instead of calculating again?
tasks/proofshare/task_request.go
Outdated
There was a problem hiding this comment.
Can we add some comments to what these individual tasks are doing?
cmd/curio/debug-snsvc.go
Outdated
There was a problem hiding this comment.
Since this is Curio command, we need to add translation.
| @@ -385,6 +385,22 @@ type CurioSubsystemsConfig struct { | |||
| // for the sector. Please ensure that TreeD and TreeRC task are enabled and relevant resources are available before | |||
| // enabling this option. (Default: false) | |||
| BindSDRTreeToNode bool | |||
|
|
|||
There was a problem hiding this comment.
Can we add default values to comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet in the final form, some data structures might still change, especially some details around payments.
Tasks are mostly done other than the Request tasks
Snap/WDPoSt support also todo