Feature: Introduced Omnibar 1 #17023
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
force-pushed
the
5bfa/CQ-OmnibarIntroduction
branch
4 times, most recently
from
f93960a to
e1ee482
Compare
yaira2
reviewed
Apr 10, 2025
yaira2
reviewed
Apr 10, 2025
yaira2
reviewed
Apr 21, 2025
yaira2
reviewed
Apr 21, 2025
src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs
Outdated
Show resolved
Hide resolved
yaira2
reviewed
Apr 21, 2025
|
I found an issue where text entered into the address bar isn't cleared after removing the focus. The easiest way to test this is by removing the focus and then refocusing the address bar. |
0x5bfa
force-pushed
the
5bfa/CQ-OmnibarIntroduction
branch
2 times, most recently
from
0aeb079 to
e4ba94d
Compare
yaira2
reviewed
Apr 22, 2025
yaira2
reviewed
Apr 22, 2025
yaira2
force-pushed
the
main
branch
2 times, most recently
from
75d29b5 to
aa7d7fa
Compare
0x5bfa
force-pushed
the
5bfa/CQ-OmnibarIntroduction
branch
from
35ce79a to
dc2399d
Compare
yaira2
reviewed
Apr 23, 2025
| IconOnActive="{controls:ThemedIconMarkup Style={StaticResource App.ThemedIcons.Omnibar.Search}, IsFilled=True}" | ||
| IconOnInactive="{controls:ThemedIconMarkup Style={StaticResource App.ThemedIcons.Omnibar.Search}, IconType=Outline}" | ||
| ModeName="Search" | ||
| PlaceholderText="Enter a search query..." /> |
There was a problem hiding this comment.
Is this supposed to use a localized string?
There was a problem hiding this comment.
Yeah Ill make them string resources right before getting this ready.
yaira2
reviewed
Apr 23, 2025
| ToolbarPathItemInvoked?.Invoke(this, new() { ItemPath = path }); | ||
| } | ||
|
|
||
| public async Task HandleItemNavigationAsync(string path) |
There was a problem hiding this comment.
Where is all this logic taken from?
There was a problem hiding this comment.
From here:
yaira2
reviewed
Apr 23, 2025
| @@ -885,6 +1030,107 @@ private static async Task<bool> LaunchApplicationFromPath(string currentInput, s | |||
| ); | |||
| } | |||
|
|
|||
| public async Task PopulateOmnibarSuggestionsForPathMode() | |||
There was a problem hiding this comment.
From here:
0x5bfa
force-pushed
the
5bfa/CQ-OmnibarIntroduction
branch
from
49fd456 to
c93e9c0
Compare
yaira2
reviewed
Apr 23, 2025
| while (shellPage.BackwardStack.Last() != itemModel.PageStackEntry) | ||
| IHomeFolder homeFolder = new HomeFolder(); | ||
|
|
||
| e.Flyout.Items.Add(new MenuFlyoutHeaderItem() { Text = "Quick access" }); |
There was a problem hiding this comment.
Please use the localized resource.
|
Two additional feedback items
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes