Skip to content

fix(ui_storage): progress is NaN when both bytesTransferred & totalBytes are 0 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

OutdatedGuy
Copy link
Contributor

Description

Checks if progress is NaN and if true, sets it to 0

Related Issues

fixes #490

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@OutdatedGuy
Copy link
Contributor Author

OutdatedGuy commented Apr 16, 2025

@russellwheatley @SelaseKay can you look into this? It is blocking me from deploying my app.

@russellwheatley russellwheatley merged commit 95b5f53 into firebase:main Apr 23, 2025
2 checks passed
@OutdatedGuy OutdatedGuy deleted the fix/progress-is-NaN branch April 23, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 TaskProgressIndicator fails due to progress being NaN
2 participants