Skip to content

Fix compilation and tests failures #8902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix compilation and tests failures #8902

wants to merge 1 commit into from

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Apr 7, 2025

No description provided.

@wu-hui wu-hui requested review from a team as code owners April 7, 2025 21:08
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3ce820b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v8.0

@wu-hui wu-hui force-pushed the push-ylruyrrpmnmz branch from 4ff3404 to 3ce820b Compare April 7, 2025 21:10
wu-hui
wu-hui commented Apr 7, 2025
View reviewed changes
Copy link
Contributor Author

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkDuckworth PTAL

I also realized that you were right, there was a getDocs(realtimePipeline) impl. I removed it for now, we can discuss with the team if an execute(realtimePipeline) is wanted.

packages/firestore/test/integration/util/helpers.ts
import { RealtimePipeline } from '../../../src/api/realtime_pipeline';
import { onPipelineSnapshot } from '../../../src/api/reference_impl';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkDuckworth This import is suspicious, just to call it out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take another look.

@wu-hui wu-hui requested a review from MarkDuckworth April 7, 2025 21:13
MarkDuckworth
MarkDuckworth reviewed Apr 7, 2025
View reviewed changes
packages/firestore/rollup.config.js
@@ -55,7 +55,7 @@ const browserPlugins = [
abortOnError: true,
transformers: [util.removeAssertAndPrefixInternalTransformer]
}),
json({ preferConst: true }),
json({ preferConst: true })
//terser(util.manglePrivatePropertiesOptions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be re-enabled

packages/firestore/rollup.shared.js
@@ -130,7 +130,7 @@ exports.removeAssertTransformer = removeAssertTransformer;
*/
const removeAssertAndPrefixInternalTransformer = service => ({
before: [
removeAsserts(service.getProgram()),
removeAsserts(service.getProgram())
// renameInternals(service.getProgram(), {
// publicIdentifiers,
// prefix: '__PRIVATE_'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be re-enabled

packages/firestore/test/integration/util/helpers.ts
import { RealtimePipeline } from '../../../src/api/realtime_pipeline';
import { onPipelineSnapshot } from '../../../src/api/reference_impl';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take another look.

@wu-hui wu-hui closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth left review comments

Assignees

@MarkDuckworth MarkDuckworth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wu-hui @MarkDuckworth