Skip to content

[FEAT] [WIP] Doc/QuerySnapshot fromJSON. #8960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: ddb-firestore-result-serialization
Choose a base branch
from

Conversation

DellaBitta
Copy link
Contributor

Discussion

WIP. Do not merge.

Add a methods to parse bundles synchronously to extract single DocumentSnapshots or QuerySnapshots containing documents. Hook the new bundle parser up the DocumentSnapshot.fromJSON and QuerySnapshot.fromJSON.

Testing

WIP.

API Changes

WIP.

Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: f0d3304

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2025

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (2d01a6d)Merge (c6c3334)Diff
    browser392 kB395 kB+2.78 kB (+0.7%)
    main605 kB609 kB+3.94 kB (+0.7%)
    module392 kB395 kB+2.78 kB (+0.7%)
    react-native392 kB395 kB+2.78 kB (+0.7%)
  • bundle

    TypeBase (2d01a6d)Merge (c6c3334)Diff
    firestore (Query Cursors)256 kB260 kB+3.22 kB (+1.3%)
    firestore (Query)263 kB266 kB+2.66 kB (+1.0%)
    firestore (Read data once)246 kB249 kB+3.22 kB (+1.3%)
    firestore (Read Write w Persistence)335 kB338 kB+2.98 kB (+0.9%)
    firestore (Realtime updates)258 kB260 kB+2.66 kB (+1.0%)
    firestore (Transaction)223 kB226 kB+3.01 kB (+1.4%)
  • firebase

    TypeBase (2d01a6d)Merge (c6c3334)Diff
    firebase-compat.js803 kB805 kB+2.29 kB (+0.3%)
    firebase-firestore-compat.js349 kB351 kB+2.29 kB (+0.7%)
    firebase-firestore.js451 kB453 kB+2.75 kB (+0.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/q4okiwR9kZ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2025

Size Analysis Report 1

This report is too large (227,938 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aZTYcDSWkJ.html

@DellaBitta DellaBitta changed the base branch from main to ddb-firestore-result-serialization April 23, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants