Skip to content

fix(vertexai): pass GenerativeModel's BaseParams to ChatSession #8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dlarocque
Copy link
Contributor

startChat wasn't passing GenerativeModel's BaseParams to ChatSession.
So, if a model had a generationConfig, it would never be passed to ChatSession.

This is how the other SDKs behave.

@dlarocque dlarocque requested a review from hsubox76 April 24, 2025 17:31
@dlarocque dlarocque requested a review from a team as a code owner April 24, 2025 17:31
Copy link

changeset-bot bot commented Apr 24, 2025

🦋 Changeset detected

Latest commit: 8801ee3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/vertexai Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dlarocque dlarocque requested review from a team as code owners April 24, 2025 17:32
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2025

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (9952dbc)Merge (f2829cf)Diff
    browser34.7 kB34.8 kB+74 B (+0.2%)
    main35.7 kB35.8 kB+74 B (+0.2%)
    module34.7 kB34.8 kB+74 B (+0.2%)
  • firebase

    TypeBase (9952dbc)Merge (f2829cf)Diff
    firebase-vertexai.js28.3 kB28.3 kB+74 B (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PEE31BlUmz.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2025

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • GenerativeModel

      Size

      TypeBase (9952dbc)Merge (f2829cf)Diff
      size18.9 kB19.0 kB+74 B (+0.4%)
      size-with-ext-deps37.9 kB38.0 kB+74 B (+0.2%)
    • getGenerativeModel

      Size

      TypeBase (9952dbc)Merge (f2829cf)Diff
      size19.1 kB19.1 kB+74 B (+0.4%)
      size-with-ext-deps38.1 kB38.1 kB+74 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/V7p7MQQ5EK.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants