-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(share_plus): Added excludedActivityTypes support for the iOS platform. #3376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(share_plus): Added excludedActivityTypes support for the iOS platform. #3376
Conversation
Thanks for this contribution as well! We have to keep this one on hold because I plan to refactor the Your input on this topic would be appreciated as well. |
@miquelbeltran |
FYI, started working on the shareplus refactor, that should simplify adding this and other optional parameters: #3404 |
Hi, that's great! I've been studying the code in your branch. It's really well-organized and tidy. Next, I need to add the parameter excludedActivityType for this pull request (PR) to ShareParams. After that, I'll wait for you to finish merging xx into the main branch. Once that's done, I'll synchronize my changes accordingly. |
# Conflicts: # packages/share_plus/share_plus/ios/share_plus/Sources/share_plus/FPPSharePlusPlugin.m # packages/share_plus/share_plus/lib/share_plus.dart # packages/share_plus/share_plus/lib/src/share_plus_linux.dart # packages/share_plus/share_plus/lib/src/share_plus_web.dart # packages/share_plus/share_plus/lib/src/share_plus_windows.dart # packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart # packages/share_plus/share_plus_platform_interface/lib/platform_interface/share_plus_platform.dart # packages/share_plus/share_plus_platform_interface/test/share_plus_platform_interface_test.dart
@miquelbeltran |
Thanks! I haven't looked too deep into it yet, but can you describe how it works in this PR, so I can understand the change better. And as well, add a bit of documentation about this feature on the |
Let me briefly describe the changes in this PR:
|
The iOS platform is missing the exclusion feature. This PR adds the platform exclusion functionality for iOS.
fix: #3377
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).