-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(device_info_plus): add storage information #3536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hmm iOS integration test timed out but everything else seems fine |
Also looks good to me. I want to test on devices before merging. Don't worry about simulator/emulators, we have had problems with those jobs and we need to fix them someday. |
Hey @miquelbeltran, did you have time to test this? Can I help somehow? 🙂 |
Sorry @Binozo, I've been busy with the SharePlus refactor PR, I'll try to get to this asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on iOS and it seems fine, but I need to request a couple of changes that I missed on my first look at the code:
- The Android and iOS params are named differently, one is
totalFreeSpace
and the other istotalFreeSize
, I'd prefer if the naming was consistent (or is there a reason for this?) - The new params are missing in the example, they should be added as well.
Thanks again and sorry for the delay reviewing
Oh yeah overlooked that, now it should be ready 🙂 |
Thanks for the changes, can we use |
Sure! Makes sense |
Description
Added storage info (total and free disk space) for Android and iOS.
Related Issues
None
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
No
!
in the title as explained in Conventional Commits).