Skip to content

fix(ios/mac): move existing privacy manifests into Resources folder for proper detection #3543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JPGmooder
Copy link

Description

This PR fixes an issue that caused the App Store to reject a review due to missing privacy manifests for all Plus plugins, even if privacy manifests already existed (ITMS-91061: Missing privacy manifest). To fix this, the manifests were placed in the plugin's Resources folder so that they would be properly recognized by Apple's privacy manifest verification system.

To resolve this, each plugin’s PrivacyInfo.xcprivacy file is now stored in a dedicated Resources folder at the root of the plugin (e.g., ios/Resources or macos/Resources). The corresponding s.resource_bundles path in each .podspec is updated to reflect this new location. This ensures the privacy manifests are properly detected, removing the “Missing privacy manifest” warning.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran
Copy link
Member

Hello, thanks for looking into this.

I need to remind that each package change should be done in a different PR, as we say in the contribution guidelines, this is required for our release process:

When modifying multiple packages, create a different branch and pull request per package. This facilitates maintenance, the review process, and generating changelogs.

It looks like that the existing manifests were not moved, but new files were created instead. The manifests already exist in the project and should not be duplicated.

Are there any references that say that Manifests need to be located in the Resources folder? My understanding is that it doesn't really matter as long as the podfile and the Swift package manager config point to the correct files.

@miquelbeltran
Copy link
Member

Reference from flutter/packages: https://github.com/flutter/packages/blob/6317cd601fa7031a7ad344053e54858bd59845ef/packages/ios_platform_images/ios/ios_platform_images.podspec#L29

Here the path is ios_platform_images/Sources/ios_platform_images/Resources/PrivacyInfo.xcprivacy so what we would need to do is to move e.g. packages/battery_plus/battery_plus/ios/battery_plus/Sources/battery_plus/PrivacyInfo.xcprivacy to packages/battery_plus/battery_plus/ios/battery_plus/Sources/battery_plus/Resources/PrivacyInfo.xcprivacy rather than packages/battery_plus/battery_plus/ios/battery_plus/Resources/PrivacyInfo.xcprivacy.

I am not sure if the Package.swift will need to be modified as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants