support for params having multiple values #681
Conversation
|
@ashitaprasad I am familiar with the codebase; however, I need to explore the test files further before making the necessary updates. I plan to work on that after updating codegen for all languages. In the meantime, please review the implementation and share your feedback. |
badnikhil
changed the title
|
@animator I request you to take a look(Feedback on the major changes is enough) . I've updated the code generation for all supported languages to handle parameters with multiple values. Before I move on to writing/updating tests, I just want to ensure that all changes are aligned with expectations . |
| @@ -34,14 +34,28 @@ class HttpRequestModel with _$HttpRequestModel { | |||
| _$HttpRequestModelFromJson(json); | |||
|
|
|||
| Map<String, String> get headersMap => rowsToMap(headers) ?? {}; | |||
| Map<String, String> get paramsMap => rowsToMap(params) ?? {}; | |||
| Map<String, dynamic> get paramsMap => rowsToRequestMap(params) ?? {}; | |||
There was a problem hiding this comment.
params map should have a strict datatype - Map<String, List>
| List<NameValueModel>? get enabledHeaders => | ||
| getEnabledRows(headers, isHeaderEnabledList); | ||
| List<NameValueModel>? get enabledParams => | ||
| getEnabledRows(params, isParamEnabledList); | ||
|
|
||
| Map<String, String> get enabledHeadersMap => rowsToMap(enabledHeaders) ?? {}; | ||
| Map<String, String> get enabledParamsMap => rowsToMap(enabledParams) ?? {}; | ||
| Map<String, dynamic> get enabledParamsMap { |
lib/widgets/table_request.dart
Outdated
| @@ -12,7 +12,7 @@ class RequestDataTable extends StatelessWidget { | |||
| this.valueName, | |||
| }); | |||
|
|
|||
| final Map<String, String> rows; | |||
| final Map<String, dynamic> rows; | |||
|
@badnikhil do not conversations as resolved. You have to comment if you have fixed it, then the reviewer verifies the fix and marks it is resolved. |
Sorry about that, I’ll keep it in mind from now on. |
|
@animator i have resolved the datatypes.. Also updated a widget test. |
PR Description
The request parameters were previously handled as a
Map<String, String>. I have updated this toMap<String, List<string>to support multiple valuesAdditionally, I have modified the relevant implementations to accommodate this change.
Related Issues
Checklist
mainbranch before creating this PR.flutter upgradeverified).flutter test), and they pass successfully.Added/Updated Tests?
We encourage contributors to add relevant test cases.
Development & Testing Environment